Attention is currently required from: Subrata Banik.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45571 )
Change subject: soc/intel/alderlake: Add GPIOs for Alder Lake SOC
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/alderlake/include/soc/gpio_soc_defs.h:
https://review.coreboot.org/c/coreboot/+/45571/comment/d2b6294d_dfa07ca1
PS8, Line 10: /* GPIO COMM 0 */
: #define GPP_B 0x0
: #define GPP_T 0x1
: #define GPP_A 0x2
: /* GPIO COMM 1 */
: #define GPP_S 0x3
: #define GPP_H 0x4
: #define GPP_D 0x5
: /* GPIO COMM 2 */
: #define GPD 0x6
: /* GPIO COMM 4 */
: #define GPP_C 0x7
: #define GPP_F 0x8
: #define GPP_HVMOS 0x9
: #define GPP_E 0xA
: /* GPIO COMM 5 */
: #define GPP_R 0xB
: #define GPP_SPI0 0xC
:
Thanks Furquan for the details, do you want me to fix this code ?
I had assigned the bug to Boris. Let me ping on the bug to see if he needs help or is planning to work on the changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45571
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77b9dcc46aceaf530e2054c9cacd7b026ebbb96b
Gerrit-Change-Number: 45571
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 24 Mar 2021 04:30:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment