[coreboot-gerrit] Change in coreboot[master]: drivers/soundwire/alc711: Add Realtek ALC711 soundwire device

[Anil Kumar K (Code Review)]

Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46303 )

Change subject: drivers/soundwire/alc711: Add Realtek ALC711 soundwire device
......................................................................

Patch Set 5: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/46303/4/src/drivers/soundwire/alc71... 
File src/drivers/soundwire/alc711/alc711.c:

https://review.coreboot.org/c/coreboot/+/46303/4/src/drivers/soundwire/alc71... 
PS4, Line 36: /* Bus frequency must be 1/2/4/8 divider of
            : 	supported input frequencies. */
> can go to 96 chars so probably don't need to break this line

Done

https://review.coreboot.org/c/coreboot/+/46303/4/src/drivers/soundwire/alc71... 
PS4, Line 84: 		{
            : 			/* Data Input for Speaker Path */
            : 			.port = 1,
            : 			.source = &alc711_dp1
            : 		}
            : 	}
> seems duplicated?  Is there a second port for output? […]

ACK. Hi Duncan. I updated the port info as per my understanding from datasheet. Did some basic testing - headphone jack detection and playback on headset