[coreboot-gerrit] Change in ...coreboot[master]: [WIP]mb/*: Migrate sandybridge MRC settings to devicetree.cb

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32070 )

Change subject: [WIP]mb/*: Migrate sandybridge MRC settings to devicetree.cb
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/32070/11/src/mainboard/google/butterfly/devi... 
File src/mainboard/google/butterfly/devicetree.cb:

https://review.coreboot.org/#/c/32070/11/src/mainboard/google/butterfly/devi... 
PS11, Line 29: 	register "usb_port_config" = "{
             : 		/* enabled   usb oc pin    length */
             : 		{ 1, 0, 0x0040 }, /* P0: Right USB 3.0 #1 (no OC) */
             : 		{ 1, 0, 0x0040 }, /* P1: Right USB 3.0 #2 (no OC) */
             : 		{ 1, 0, 0x0040 }, /* P2: Camera (no OC) */
             : 		{ 0, 0, 0x0000 }, /* P3: Empty */
             : 		{ 0, 0, 0x0000 }, /* P4: Empty */
             : 		{ 0, 0, 0x0000 }, /* P5: Empty */
             : 		{ 0, 0, 0x0000 }, /* P6: Empty */
             : 		{ 0, 0, 0x0000 }, /* P7: Empty */
             : 		{ 0, 4, 0x0000 }, /* P8: Empty */
             : 		{ 1, 4, 0x0080 }, /* P9: Left USB 1 (no OC) */
             : 		{ 1, 4, 0x0040 }, /* P10: Mini PCIe - WLAN / BT (no OC) */
             : 		{ 0, 4, 0x0000 }, /* P11: Empty */
             : 		{ 0, 4, 0x0000 }, /* P12: Empty */
             : 		{ 0, 4, 0x0000 }, /* P13: Empty */
             : 	}"
> Sure, the idea is to avoid deduplication.

oops, double negative. the idea is to avoid *duplication ._.