Peter Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35131 )
Change subject: mb/google/hatch/var/kindred: Update DPTF parameters and TDP PL1/PL2
......................................................................
Patch Set 2:
(2 comments)
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35131/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/35131/2/src/mainboard/google/hatch/...
PS2, Line 83: 80, 70, 60, 50, 40, 30
Do we really need these? You have defined only DPTF_CPU_ACTIVE_AC0 entry above.
Hi Sumeet
At the moment these numbers don't work, but they might be used in the next stage, so I put them in the table first.
https://review.coreboot.org/c/coreboot/+/35131/2/src/mainboard/google/hatch/...
PS2, Line 87: 100, 80, 70, 60, 50, 40, 30
same as above, do we need these? There is no entry above for DPTF_TSR0_ACTIVE_AC*.
This setting is same as the CPU, and we will verify it in the next stage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1817e277f4641db6bedc8b640b1dc5d57502d5dd
Gerrit-Change-Number: 35131
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Han Chen
han.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Jack Lai
jack.lai@intel.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Teresa Tseng
teresa_tseng@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Grace Kao
grace.kao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 30 Aug 2019 13:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment