Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34449 )
Change subject: soc/intel/common: Set controller state to active in GSPI init
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34449/8/src/soc/intel/common/block/...
File src/soc/intel/common/block/gspi/gspi.c:
https://review.coreboot.org/c/coreboot/+/34449/8/src/soc/intel/common/block/...
PS8, Line 462: device = pcidev_path_on_root(devfn);
The validity of device needs to be checked, because this GSPI device is not enabled on all SoCs.
Actually I am observing a crash due to device being NULL in APL/GLK i.e. the device is passed to lpss_set_power_state which hits pcidev_assert and dies because device is NULL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34449
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f95059453ca5565a38650b147590ece4d8bf5ed
Gerrit-Change-Number: 34449
Gerrit-PatchSet: 8
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Aug 2019 19:26:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment