7 Jan
2022
7 Jan
'22
3:06 p.m.
Attention is currently required from: Maulik V Vaghela, Rizwan Qureshi, Tim Wawrzynczak, Reka Norman, Usha P. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60896 )
Change subject: mb/intel/adlrvp_n: Configure EC in RW GPIO ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/intel/adlrvp/chromeos.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137584): https://review.coreboot.org/c/coreboot/+/60896/comment/76c5959a_a9e46aab PS1, Line 54: #if (CONFIG(BOARD_INTEL_ADLRVP_P_EXT_EC) || CONFIG(BOARD_INTEL_ADLRVP_M_EXT_EC)) || CONFIG(BOARD_INTEL_ADLRVP_N_EXT_EC) line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/60896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8b6be9fcda24bd2bb479b5b6c01f24a6e9c7b1f
Gerrit-Change-Number: 60896
Gerrit-PatchSet: 1
Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P usha.p@intel.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Usha P usha.p@intel.com
Gerrit-Comment-Date: Fri, 07 Jan 2022 13:06:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment