Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41345 )
Change subject: mb/google/volteer: fix error in generic SPD
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41345/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41345/8/src/mainboard/google/voltee...
PS8, Line 8:
It did. […]
leading tabs in makefiles make me nervous because they have semantic significance... in most places. this is not one of them... i had to double check 😊
starting the line with '#' would be safest.
if you want to scrub white spaces as a follow-up, i'm OK with that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib52bf674ebf91854d3d078015aa640aa7ee98a6f
Gerrit-Change-Number: 41345
Gerrit-PatchSet: 8
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 May 2020 23:14:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment