Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32532 )
Change subject: security/vboot/vboot_crtm.h: Remove ENV_ for vboot_measure_cbfs_hook()
......................................................................
Patch Set 6:
The error 'undefined vboot_measure_cbfs_hook' will occur when both VBOOT and VBOOT_MEASURED_BOOT configs are enabled. The function definition of vboot_measure_cbfs_hook() is enabled, but the voot_ctrm.c is not included in bootblock.
(I did a quick test adding vboot_crtm.c for bootblock, but this result in new build errors missing support in bootblock)
I think this is the right solution, but it turned out our dead code elimination wasn't quite as efficient as I hoped yet. Please rebase onto my three patches ending in CB:32716, I think then it should work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic62c18db09c119dfb85340a6b7f36bfd148aaa45
Gerrit-Change-Number: 32532
Gerrit-PatchSet: 6
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 May 2019 21:21:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment