Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@7 PS1, Line 7: google/kukui: boot up sspm please split into two patches, one for 8183/SSPM, and then another to add SSPM for kukui.
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: cbfs CBFS
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: bring up it enables SSPM
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: sspm SSPM
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/sspm.c File src/soc/mediatek/mt8183/sspm.c:
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/sspm.c@22 PS1, Line 22: #define SSPM_UART 1 this should be a Kconfig value
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/sspm.c@31 PS1, Line 31: write32 a command for what this triggers - resetting SSPM ? or also loads the CFG_SSPM_SRAM etc?