Attention is currently required from: Sean Rhodes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 16:
(363 comments)
File util/coreboot-configurator/src/Documentation.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/df863f14_ee95072f PS16, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'?
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0b18beb4_faad66fb PS16, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4a45d118_e4f514e5 PS16, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7e028095_51b586c2 PS16, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bf0f8c57_742ffbce PS16, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a303112f_8a766efe PS16, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3ec28df9_0a288207 PS16, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/03bdd538_84964afa PS16, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cf1f1543_2c730b7c PS16, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d78a7eab_db740e1f PS16, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3a0acba6_fa6481e0 PS16, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d6c1bf9a_ea664bcf PS16, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/410a05fc_b8ec5a04 PS16, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1a13fe3a_efb5fc2d PS16, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/992d7359_8f9404f9 PS16, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dae99d9d_1ab9d36c PS16, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/622fb4dc_866f92de PS16, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/16f21e5f_a1f209fd PS16, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5cb8e6df_599a2106 PS16, Line 37: void showEvent(QShowEvent *ev); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9c59b30f_0e20376d PS16, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f070c62c_b904ba5b PS16, Line 38: void closeEvent(QCloseEvent *ev); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/11509c8e_30547a0e PS16, Line 42: void closeWindow(int result); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dbdf30a4_5933b68f PS16, Line 43: void saveAndClose(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4f9f295d_acc88041 PS16, Line 46: void getSettings(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ec547c0c_f76a1722 PS16, Line 47: void getFromFile(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/565dc52b_b690909e PS16, Line 48: void displaySettings(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b7a66ce4_e0db8c88 PS16, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/27f7099a_16e58fdf PS16, Line 51: void writeSettings(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9da1b464_b3af4b5c PS16, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c8f3a7a7_0130532c PS16, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/988b28f3_2fe5b867 PS16, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7c63e25f_3a82d068 PS16, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a107e32d_440f2019 PS16, Line 59: QString m_fileName; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bc640178_aca8eed5 PS16, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5b8c2be9_a80f4219 PS16, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5a99ea18_6df14044 PS16, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/732bdf44_4af502b6 PS16, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f1c207c8_e45fcb35 PS16, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/eeab1a67_91aa834a PS16, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fff24ca1_c9963aa7 PS16, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2d91aab7_871d5ed5 PS16, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6c21e6c1_0cdf8ffe PS16, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dce61de4_f2b7c51a PS16, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1f3e30ca_c1f96f2d PS16, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/520cbf51_0a720b03 PS16, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4fe1af18_941b8b0d PS16, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/76283869_42641f35 PS16, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f97e013a_febba75c PS16, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fbeb8508_72a41916 PS16, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d75452c1_93d905de PS16, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dd8bee5f_a36e53de PS16, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/28130000_f5d39c36 PS16, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8ae6fbfb_48cb9075 PS16, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/39655844_c752e82f PS16, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/30b98118_79878984 PS16, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/63fe2c47_c19daf20 PS16, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/41b77e8a_17592e94 PS16, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/113cefd8_142747dd PS16, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f79ec5fb_d68983ed PS16, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4d978d0a_0cb4fbd7 PS16, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/16769760_40944dd6 PS16, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/249b9c07_399667aa PS16, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d3287ae1_edcbf9a7 PS16, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3624225b_bd0fa6df PS16, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/52e97d3a_593b5266 PS16, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9f25e8ba_410d2e5e PS16, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8588e4e5_f3c3679f PS16, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/066182a2_5d0abd3c PS16, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c28f8281_5b7c143f PS16, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5867f4fa_23dd6413 PS16, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/43e9d577_2d94d835 PS16, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c0c64bb3_4c09e521 PS16, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d591a1e9_85e68aee PS16, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/595f25f7_358ea3ac PS16, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3e8fcd0f_d8ebf383 PS16, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7c3d1783_e195e92e PS16, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c6762d2e_555dbac4 PS16, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dce86d07_498e4c98 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/493700ad_ccd77b94 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dde0d4e8_c4c00c46 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6255b632_7baa551b PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f038710d_96719ce0 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3f8922d3_86fcd6e4 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f0d9137e_dc98894c PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/27295f06_71413cb5 PS16, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d97fd658_9239a62b PS16, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5cdcc0d2_f90864e6 PS16, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/25149b27_69bb61aa PS16, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d1e5c3f7_37ae9052 PS16, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a75485b4_54a0a322 PS16, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ed3dc88c_7f029ca5 PS16, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5e1c470a_7d14820b PS16, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4a20594a_6c26f1d6 PS16, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ed985308_ef5d8b77 PS16, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4d2fa72b_3abe6715 PS16, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9d14b8cc_1a46e5a0 PS16, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2b0268e3_2f5b8d82 PS16, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e39b2635_13464523 PS16, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ba9fe07c_773aac28 PS16, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d1397749_72f0914e PS16, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f028958a_e4b01ff1 PS16, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/96bbf7e9_917c48cc PS16, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cd0c50ec_dae89c38 PS16, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a58a29d6_2633014e PS16, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7118b4fe_7b9e1a8e PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/28b9c428_7fcb821f PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/61229030_2c50fd59 PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c4b7b0f4_15c0ee2b PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fcef53e3_1a3c010a PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9a6c99cd_180aae32 PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d078da5b_39ead11c PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fd9d94ae_77ce3bd3 PS16, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7ef1be23_3e3dd01d PS16, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7185d28e_15ce0db6 PS16, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4b199335_904e492d PS16, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fb13976e_fd2a7f92 PS16, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4c5873bb_774134d1 PS16, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0f1aed63_74318f73 PS16, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e55a7972_926e0e2d PS16, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d8cbe6cf_12630be2 PS16, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/105ed566_4ff745e7 PS16, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/11bcc8e2_357ce93f PS16, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e3e2fe9b_803a67ee PS16, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5a1b0305_13835ccc PS16, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/931ee3bf_30c64426 PS16, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/355bd739_53979900 PS16, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c19207b3_805a74da PS16, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/edcf3159_1040e1fa PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dfd9eefa_efac577e PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/39d03d26_ccb48860 PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0d1a53af_7005b8ff PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f5e939df_0f478787 PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4727f7fb_d5309220 PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/418770b0_f9fda917 PS16, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b232e529_436ed528 PS16, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/60a8c127_342ae484 PS16, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1312e7f8_51ffd0ae PS16, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fc53fb17_d8649df4 PS16, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6b6dc79c_f1c5a529 PS16, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a6473691_369c59ee PS16, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/85ce1a1f_a1f1d9d7 PS16, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e4899fe7_deca2542 PS16, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c3c6bf31_3f23a392 PS16, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/11229b45_49c07dfd PS16, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8c1476a6_60cb4ea5 PS16, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/92fc7310_19952907 PS16, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5f516bf4_2ebe6896 PS16, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/091690d2_b00ec25d PS16, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c466d125_c4e46750 PS16, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dc17f48f_116614e2 PS16, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/43863e7b_b35feeec PS16, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5cbf13e1_e21c973a PS16, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3cee2508_a5a6a7b5 PS16, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f52acdd9_e70f32d0 PS16, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9b4e16aa_7bf4125a PS16, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0755f35d_4aed82c4 PS16, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6832d8e7_522734d5 PS16, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1e27fb48_040305d9 PS16, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7752b705_ba2906a2 PS16, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6f439c65_30efdd95 PS16, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2396ed87_39510d2c PS16, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e2029361_85598c90 PS16, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/19fff2fd_99e3f862 PS16, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1c139bed_9bf78836 PS16, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d4463aa1_499e8789 PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/afc06cf0_9901418c PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d06df76c_5acfc1ea PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/85dfefdd_3d7e13b8 PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5b72e106_d776cd73 PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ab8e9e83_e15a2825 PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b94693dd_4864072e PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0af6f1b0_d8bd695a PS16, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7dce9ccb_a333c279 PS16, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a9877a22_db081467 PS16, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f86c0e84_d25116d4 PS16, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8cb61e57_852a1c98 PS16, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/52405c6c_c203bd42 PS16, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3cf16dea_3644c9f8 PS16, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2df19fb3_eebad69d PS16, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b4da854e_3bf257f0 PS16, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a90c03f8_8a8965a1 PS16, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a7f11227_04cc66b2 PS16, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/25c34895_baf3a2be PS16, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c0705030_c62a6f5a PS16, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6f01fcb5_99bad715 PS16, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bf4f3927_fce2f6f5 PS16, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e0c11161_53d3ccce PS16, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/85c6c9fb_3e41713a PS16, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2e9049b4_9d054a2e PS16, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dd56870b_62c3b61c PS16, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cf0dee5e_32f54baf PS16, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1ad304e2_bb547b33 PS16, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/627924c1_ab681329 PS16, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d69e22ff_bdf5f304 PS16, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/90390e6a_3135418c PS16, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6b2bf4a3_816f5a4a PS16, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9f541630_afffa5d5 PS16, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/08baf9bd_5caf3bd0 PS16, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/75230521_699db50d PS16, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ec4de567_5cc9d936 PS16, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/91b1b373_296b0036 PS16, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9c04e7af_eb153c1f PS16, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1a0b6825_0d3d7015 PS16, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dc81ed4f_6ae99ec6 PS16, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c8009983_feec2ba9 PS16, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/96108c4c_21650a4b PS16, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d24e236a_f462d54d PS16, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7c35720f_3683ccd5 PS16, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/aa0a80bd_11df2177 PS16, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/df30c090_baeb8a3e PS16, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2a5ce831_9ab02799 PS16, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cb7fb3ae_f64985bc PS16, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9ebeaf8f_bfff5725 PS16, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3192f4fa_76fea01a PS16, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fa485198_392412bd PS16, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4a3a97dc_2ec09829 PS16, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e842680f_906d470d PS16, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0f59785c_5a3ea993 PS16, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e2fa0403_b94d0c3a PS16, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d99ebe3e_c4b3cda3 PS16, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9bfbfb48_bdbc1a2b PS16, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/10be4db5_e732330e PS16, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/84a5614d_d59f157f PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/555c5296_1157e5ab PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8417e37a_21341b18 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b1f58178_974a0985 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0c4649e5_ef03bf13 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/131c2b1a_0b62ae58 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e552283a_2f4b0738 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/63d049d4_695299fa PS16, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/46d2196f_e7da2a81 PS16, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/db5e60aa_42835702 PS16, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b2cbf354_09134e58 PS16, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f4d32558_a0eaaf90 PS16, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c7fb9433_7abb9089 PS16, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0c93e943_6deba94d PS16, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d6932518_800eee4d PS16, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/909219c2_d7c60d8e PS16, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1ceb71ed_a1a46f13 PS16, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f867ef62_2a371ffc PS16, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f6cba361_476eed48 PS16, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5a170241_c0d05a7d PS16, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5de4b3da_c3601526 PS16, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6ba4fab3_b346bcec PS16, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a4d079dc_9165d142 PS16, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e19a8121_2a85f6b3 PS16, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/317a208d_a61b5711 PS16, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3c7a2016_34fc3ac2 PS16, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7a47cec9_3e1a4c6f PS16, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/51879ecf_ceabe0b9 PS16, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9e365e9a_2566bb2c PS16, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3466cc17_ba004227 PS16, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/468dec0a_138941e5 PS16, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c7ca1b2c_ad54d428 PS16, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2beef1d1_59162fd4 PS16, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5d799e0e_316092b9 PS16, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d1251557_d3ea4637 PS16, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9334a450_9459414b PS16, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/47e7c867_f797d50c PS16, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/44ddbfb9_e010d75f PS16, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b6078ec7_242c808f PS16, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bffc5e57_9185bf7d PS16, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2b816d00_bb8c1a49 PS16, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c54eeaa1_3962e412 PS16, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8c3bea63_9906ef9d PS16, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/05fb9f50_0ae602b3 PS16, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5be85854_24e321af PS16, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/df68fa85_cb4b3e2e PS16, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c2081f86_99c5111f PS16, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fe7cb6a7_dba32cd5 PS16, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f23da2c8_6bab6497 PS16, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b7908f58_115fd21e PS16, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f6322dee_82c148da PS16, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bc3ebcd0_771bb23f PS16, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f9e3be89_647d89bc PS16, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/65f07637_7e6f6810 PS16, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/884968e0_72b83d81 PS16, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/42ae4924_b72f6b9f PS16, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/24bc1065_94832bba PS16, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3a0467ba_6ff66bdc PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d560b768_9de88721 PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b13e262a_c98f919c PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b514cd93_bc8bf5b7 PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b693eb6c_484b3626 PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/82b4eaa6_cc2fecef PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/94b8fa3f_b0e4ba0c PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/53efc16d_6a76f426 PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0553bbc2_6fe9a746 PS16, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f20fc1c2_e4808e2d PS16, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dc5a1161_193293a0 PS16, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/124147ba_f3b823a0 PS16, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/483e76e7_0b82826b PS16, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/789f14a6_520fa082 PS16, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5b066d26_a251a922 PS16, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1b57ab7d_53066d40 PS16, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0c7c672e_eff8af5b PS16, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5b1116b1_8f1091bb PS16, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cefb3de9_301f3a04 PS16, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f3b71172_f8ae3e84 PS16, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/52769ea4_1e64d302 PS16, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6fb99135_cd03ec86 PS16, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f5776709_f44f492e PS16, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8dd3525f_fa1c8b8e PS16, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c2b9dc71_c1fca39a PS16, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c1e11709_4e6267ce PS16, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7ed7abcc_090c6271 PS16, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6ea67487_de776818 PS16, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/56c96dd2_bd897670 PS16, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/42ff36c2_db0f8e74 PS16, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f15c50a1_acb9294e PS16, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e6ac21bd_9b9a75ea PS16, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e4d72369_0aefbbc4 PS16, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/27d41c01_2cd5557d PS16, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/01db8bbc_b3944264 PS16, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4e1ee08b_57358ef6 PS16, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/441fc661_453be02a PS16, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d4f9dbf7_ef311b6b PS16, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7b7b72b8_ab94b67b PS16, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/46102b37_25783392 PS16, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3a7f4506_1d97a523 PS16, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/61ed20db_7532238a PS16, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9081506b_c1c95d36 PS16, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dfb1a48b_a79cb911 PS16, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ef14011e_88506f22 PS16, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b4694de6_6ce6660e PS16, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1182afa2_15ef58f5 PS16, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5584435c_f9929f03 PS16, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/635d718b_8f6e0381 PS16, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/66325bef_c2fce6e5 PS16, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a45ffbb8_d8db54f6 PS16, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3c28c962_df8b2d54 PS16, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1c6a706a_580dc5d7 PS16, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1825a1b7_7a671e62 PS16, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8cba00f1_dc8f7e4f PS16, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/89b4ef29_ccd413a9 PS16, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cb1c603e_bd728095 PS16, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cfe2ddcd_f94ae88b PS16, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b66e6951_c17378b1 PS16, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0e6975fb_b7c7502d PS16, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d4715219_1d2fadd6 PS16, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f61b3d64_cea119e4 PS16, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/352edf8c_c0b1b0c1 PS16, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/03ea093a_0e117b8f PS16, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5536cce0_78129ac6 PS16, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/50e397ee_4171731f PS16, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/39aeffc3_1c2a4e07 PS16, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3f538055_69121197 PS16, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/68d63a26_a245e111 PS16, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/95674cd9_73d2e05b PS16, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2b244478_7523dfeb PS16, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d0e00769_92934df8 PS16, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/76650ce4_acb869e0 PS16, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ff4c85c4_174bcfbb PS16, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f2310b35_a82af468 PS16, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ddbe23fc_5bb7b88d PS16, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/89c8808e_62a0a394 PS16, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b386e3b3_91f6e5b9 PS16, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d25d58fb_47abf674 PS16, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c12c9e6f_3a0ecd11 PS16, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5698fa14_87a13b26 PS16, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a223470d_ba17d158 PS16, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fe4af770_b497d4e4 PS16, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ccaa0b0c_79671e3b PS16, Line 188: } please, no spaces at the start of a line