Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, chris wang.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49932 )
Change subject: soc/amd/picasso: allow USB_PD port setting override
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/49932/comment/8675603a_7c291c45
PS6, Line 279: de
When would these settings need to be overwritten?
those settings need to be overwritten, when the type c capable ports are used as type a usb or display port and there is no EC or PD controller in the system that writes the registers to the right value via I2C4. it's an override for the type C RF mux
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd559b67668846805005a6e00f5a84655310f348
Gerrit-Change-Number: 49932
Gerrit-PatchSet: 6
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Wed, 27 Jan 2021 18:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment