Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45306 )
Change subject: trogdor: Move EN_PP3300_DX_EDP for Coachz
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
(1 comment)
Do we still want to support TROGDOR_REV0?
Unfortunately, I think the answer is yes for now. We're still low on hardware and I think people are still using old trogdor-rev0 boards out there. I actually still use mine, too, since it's hooked up to my PC at work and I haven't been able to go in and switch to newer hardware there.
Oh, ok, LGTM then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00ad6a6249df66006b4f2b953a0a2449bd478f6d
Gerrit-Change-Number: 45306
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Assignee: Philip Chen
philipchen@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Douglas Anderson
dianders@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 18 Sep 2020 21:10:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment