Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39346 )
Change subject: soc/intel/common: add processor power limits control support
......................................................................
Patch Set 25:
(2 comments)
Patch Set 25:
Would you mind stacking these all in one single chain? Whenever I go visit a specific SoC-change on top of this, it seems they all have the same parent, which is this one.
I have created this intentionally because I did not find any dependencies between these SoC-changes with each other, for an example there is no dependencies between tigerlake patch and skylake patch.
Also, I though if all these in one single chain, that would create unnecessary dependencies between SoC-chagnes and if one breaks in Jenkin build, all other fails considering dependencies between them. So, keeping independent this approach reduces Jenkin build failures as well.
Keeping them as independent would help to track, review, portability and easy to cherry pick for product specific firmware branches.
Please, correct if this way of independent implemention is improper or suggest any other better approach. Thanks.
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/cannonlake/f...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/cannonlake/f...
PS22, Line 157: struct soc_power_limits_config *soc_confg;
Ack
Done
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/acpi/...
File src/soc/intel/common/acpi/dptf.asl:
PS22:
This is required to add TCPU zone for thermal control.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41fd95949aa2b02828aa2d13d29b962cb579904a
Gerrit-Change-Number: 39346
Gerrit-PatchSet: 25
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 15 May 2020 17:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment