Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35867 )
Change subject: mb/[google/intel/lenovo]/*: fix posix shell bug with SPD files
......................................................................
Patch Set 1: Code-Review+2
Patch Set 1:
I don't really see an advantage of using these hex files over just plain binaries...
different kind of fix for the problem, though ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95b414d959e5cd4479fcf100adcf390562032c68
Gerrit-Change-Number: 35867
Gerrit-PatchSet: 1
Gerrit-Owner: greg@unrelenting.technology
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: greg@unrelenting.technology
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 09 Oct 2019 22:16:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment