Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38785 )
Change subject: mb/pcengines/apu2: Remove unnecessary initialization
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38785/1/src/mainboard/pcengines/apu...
File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38785/1/src/mainboard/pcengines/apu...
PS1, Line 231: return len;
if you do: […]
True, but in this case, I would keep it to not duplicate the calculation twice, and a variable makes sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b42dcd564480005b2c520316933940d87b6e418
Gerrit-Change-Number: 38785
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 11 Feb 2020 11:47:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment