Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43133 )
Change subject: baytrail RFC: native replacement for refcode.elf
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43133/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43133/4//COMMIT_MSG@10
PS4, Line 10: What should be done with all the magic numbers?
They aren't magic if they appear on document #538136 (atom e3800 datasheet) 😄
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91977c509022b0078804dc151d27296260e24bc4
Gerrit-Change-Number: 43133
Gerrit-PatchSet: 4
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 05 Jul 2020 12:55:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment