Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: mediatek/mt8183: Use cached calibration result for faster bootup ......................................................................
Patch Set 29:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35164/23/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35164/23/src/soc/mediatek/mt8183/dr... PS23, Line 858: dramc_rx_dqs_gating_cal2
@huayang I have no idea how to name this function. […]
Renamed to dramc_rx_dqs_gating_cal_partial.
https://review.coreboot.org/c/coreboot/+/35164/28/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35164/28/src/soc/mediatek/mt8183/dr... PS28, Line 1873: if (dramc_check_dqdqs_win(&(win_perbit[bit]),
Too many leading tabs - consider code refactoring
Done
https://review.coreboot.org/c/coreboot/+/35164/28/src/soc/mediatek/mt8183/dr... PS28, Line 1877: if (vref_scan_enable)
Too many leading tabs - consider code refactoring
Done
https://review.coreboot.org/c/coreboot/+/35164/28/src/soc/mediatek/mt8183/dr... PS28, Line 1880: if (bit % DQS_BIT_NUMBER == 7)
Too many leading tabs - consider code refactoring
Done