[coreboot-gerrit] [M] Change in coreboot[main]: vendorcode/amd/opensil: Add initial setup and API calls

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Martin L Roth.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76515?usp=email )

Change subject: vendorcode/amd/opensil: Add initial setup and API calls
......................................................................

Patch Set 6:

(2 comments)

File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:

https://review.coreboot.org/c/coreboot/+/76515/comment/75affd2e_d43e2482 :
PS6, Line 7: 	
might be good to do the whitespace changes in a separate patch. same below in lines 59 and 170

File src/vendorcode/amd/opensil/genoa_poc/ramstage.c:

https://review.coreboot.org/c/coreboot/+/76515/comment/0964724c_78de042a :
PS6, Line 86: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT_CHIPS, BS_ON_EXIT, opensil_entry, (void *)SIL_TP1);
we should probably look into removing the BOOT_STATE_INIT_ENTRY in this file and have the few calls in the soc code or possibly some common amd opensil code to have more control over the timing of those calls. i'd say adding a TODO comment for this should be the way to go here