Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33273 )
Change subject: ifdtool: Enable GbE/PDR region access if they exist ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33273/3/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/#/c/33273/3/util/ifdtool/ifdtool.c@999 PS3, Line 999: fmba->flmstr3 |= (1 << REGION_GBE) << rd_shift; : fmba->flmstr3 |= (1 << REGION_GBE) << wr_shift; I'm not sure these settings have much effect since the SPI programming guide says that GbE master always has RW access to GbE region, etc, but there are bits for it so we might as well program them as we expect them to be used.