26 Mar
2020
26 Mar
'20
6:41 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39769 )
Change subject: nb/intel/haswell: Implement proper backlight PWM config ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39769/6/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/39769/6/src/northbridge/intel/haswe... PS6, Line 365: 1 << 5
Angel, what do you think? You found it in the documentation; do you think […]
Well, i915 calls it LPT_PWM_GRANULARITY... Since we also use the SOUTH_CHICKEN2 name from i915, it makes sense to use a #define
--
To view, visit https://review.coreboot.org/c/coreboot/+/39769
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17dfe1a3610d5e2918c617cf5d10896692fdccb3
Gerrit-Change-Number: 39769
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 26 Mar 2020 09:41:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org
Gerrit-MessageType: comment