build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38840 )
Change subject: mainboard: Add OCP Tioga Pass board ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38840/3/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/38840/3/src/mainboard/ocp/tiogapass... PS3, Line 16: unsigned long acpi_fill_madt(unsigned long current) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/38840/3/src/mainboard/ocp/tiogapass... PS3, Line 21: void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/38840/3/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38840/3/src/mainboard/ocp/tiogapass... PS3, Line 14: void bootblock_mainboard_early_init(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/38840/3/src/mainboard/ocp/tiogapass... PS3, Line 23: pci_mmio_write_config32(PCH_DEV_LPC, 0x80, (1<<28) | (1<<16) | (1<<17) | (0 << 0) | (1 << 4)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38840/3/src/mainboard/ocp/tiogapass... PS3, Line 28: if (CONFIG(BOOTBLOCK_CONSOLE)) { braces {} are not necessary for single statement blocks