Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35643 )
Change subject: util/intelp2m: add Intel Pad to Macro util [WIP]
......................................................................
Patch Set 16:
According to the documentation, host softaware owenership is used only for GPI
pads, however AMI firmware sets this bit to 1 for NF and GPO. Perhaps these
registers uses OS Windows, but I think the documentation about this isn't publicly
available )
Do we need to add new macros to soc/intel/common/block/include/intelblocks/gpio_defs.h
for NF and GPO that will take HS ownership into account? Or should we ignore the
value in the HOSTSW_OWN_* registers for NF and GPO pads and use standard macros from gpio_defs.h?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3e3b523c4f63dc2f91e9ccd16934e3a1b6e21fa
Gerrit-Change-Number: 35643
Gerrit-PatchSet: 16
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Maxim Polyakov
m.poliakov@yahoo.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 14 Apr 2020 14:25:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment