Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39346 )
Change subject: soc/intel/tigerlake: Add processor power limits control support ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39346/8/src/soc/intel/tigerlake/cpu... File src/soc/intel/tigerlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/39346/8/src/soc/intel/tigerlake/cpu... PS8, Line 103: void set_power_limits(u8 power_limit_1_time) This whole thing looks awfully similar to skylake and cannonlake. Seems like this might be another good candidate to move to soc/intel/common ? set_power_limits() can then take const pointers to the sec_to_msr and msr_to_sec arrays if they differ between SoCs.