Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37935 )
Change subject: src/*.asl: Remove _HID / _ADR objects
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37935/3/src/soc/intel/broadwell/acp...
File src/soc/intel/broadwell/acpi/serialio.asl:
PS3:
all broadwell boards with i2c devices have sio_acpi_mode set to 1. […]
Ah, "with i2c devices" made me look again. For the boards that set
`sio_acpi_mode = 0` those lines are redundant twice indeed, they
don't have SIO devices...
Would be a shame to loose functionality (there are more OSes out there
than Windows and Linux), but I wouldn't object if you want to drop
`sio_acpi_mode`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37935
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I949393558f5af66689c167b2e593a1461f641962
Gerrit-Change-Number: 37935
Gerrit-PatchSet: 3
Gerrit-Owner: Jonas Moehle
ad-min@mailbox.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jonas Moehle
ad-min@mailbox.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Tue, 31 Dec 2019 14:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment