Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53922 )
Change subject: soc/amd/common/block/pci: Introduce struct pci_routing_info ......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/common/block/include/amdblocks/amd_pci_util.h:
https://review.coreboot.org/c/coreboot/+/53922/comment/cf1743ca_b8e2f43f PS3, Line 34: enum pci_routing_swizzle { : PCI_SWIZZLE_ABCD = 0, : PCI_SWIZZLE_BCDA, : PCI_SWIZZLE_CDAB, : PCI_SWIZZLE_DABC, : }; hmm, is this even used? this is also already implicitly defined in pcie_swizzle_table
https://review.coreboot.org/c/coreboot/+/53922/comment/7fac9842_9e093917 PS3, Line 47: struct pci_routing_info { should this be marked as packed, since this is what we get from fsp via hob?