Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG@15
PS1, Line 15: - keep GPIO_67 and GPIO_117 high and
: - pull down GPIO_161 for 30ms then release it.
Indentation for lists is not needed. You might loosely follow [Markdown][1]. […]
Done
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG@16
PS1, Line 16: - pull down GPIO_161 for 30ms then release it.
since this patch aims to invoke the function already existed for reboot power state, so I update the […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I825cefb524ddaf9a9cb6add31c2ee0eea484f978
Gerrit-Change-Number: 46022
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 05:02:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chiu
Kevin.Chiu@quantatw.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment