26 Nov
2021
26 Nov
'21
9:42 a.m.
Attention is currently required from: Shelley Chen, Hung-Te Lin, Jianjun Wang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56791 )
Change subject: soc/mediatek: Add PCIe support ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56791/comment/11917e04_925aebbc PS3, Line 11: 1. What datasheets (name, revision and section) were used to implement this? 2. How has this been tested?
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/56791/comment/27557066_71cba0ba PS3, Line 85: static inline int mtk_fls(int x) Should this be a common function?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b6adaafa20aeee136372ec9564273f86776da0
Gerrit-Change-Number: 56791
Gerrit-PatchSet: 3
Gerrit-Owner: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 26 Nov 2021 08:42:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment