Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40525 )
Change subject: soc/mediatek/mt8183: Use term settings for high DRAM frequency ......................................................................
Patch Set 8:
(9 comments)
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG@7 PS7, Line 7: High frequency of DRAM should use term settings
Use term settings for high DRAM frequency
Done
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG@9 PS7, Line 9: should
This can be removed.
Done
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG@10 PS7, Line 10: that large than
larger than
Done
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG@10 PS7, Line 10: the
Fit into previous line.
Done
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG@11 PS7, Line 11: should enable the term to improve the signal integrity.
Is that mentioned in some datasheet?
4.29 Command Bus Training The LPDDR4-SDRAM command bus must be trained before enabling termination for high-frequency operation. LPDDR4 provides an internal VREF(CA) that defaults to a level suitable for un-terminated, low frequency operation, but the VREF(CA) must be trained to achieve suitable receiver voltage margin for terminated, high-frequency operation.
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG@11 PS7, Line 11: should
This can be removed also.
Done
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG@13 PS7, Line 13: 153614919
b:153614919
Done
https://review.coreboot.org/c/coreboot/+/40525/7/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/40525/7/src/soc/mediatek/mt8183/dra... PS7, Line 281: 0x%x
%#x
Done
https://review.coreboot.org/c/coreboot/+/40525/7/src/soc/mediatek/mt8183/dra... PS7, Line 1837: vref_begin = params->tx_vref[chn][rank] | (vref_range << 6);
The current line length limit is 96 characters.
Ack