build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/32604/4/src/mainboard/apple/macbookair5_2/ma... File src/mainboard/apple/macbookair5_2/mainboard.c:
https://review.coreboot.org/#/c/32604/4/src/mainboard/apple/macbookair5_2/ma... PS4, Line 22: RCBA32(0x38c8) = 0x00002005; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32604/4/src/mainboard/apple/macbookair5_2/ma... PS4, Line 29: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); line over 80 characters
https://review.coreboot.org/#/c/32604/4/src/mainboard/apple/macbookair5_2/ma... PS4, Line 29: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32604/4/src/mainboard/apple/macbookair5_2/ro... File src/mainboard/apple/macbookair5_2/romstage.c:
https://review.coreboot.org/#/c/32604/4/src/mainboard/apple/macbookair5_2/ro... PS4, Line 37: printk(BIOS_INFO, "MacBook Air: pch_enable_lpc\n"); Prefer using '"%s...", __func__' to using 'pch_enable_lpc', this function's name, in a string