Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31510 )
Change subject: AGESA binaryPI: Sync STRUCT_NAME definitions ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31510/3/src/vendorcode/amd/pi/00660F01/AMD.h File src/vendorcode/amd/pi/00660F01/AMD.h:
https://review.coreboot.org/#/c/31510/3/src/vendorcode/amd/pi/00660F01/AMD.h... PS3, Line 129: /* When AMD rolled out CarrizoPI, they made a bad choice of removing : * an entry from the middle of the enumeration list. : */ If I understand the history correctly, AmdS3Save was deprecated in favor of AmdInitRtb. The spec says "Both entry names will be supported for a time to maintain backward compatibility in present systems". No idea how old that note is, but my guess is CZ finally did away with AmdS3Save inside the PI.