Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38538 )
Change subject: libpayload/corebootfb: Add option to center a 80x25 console ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/Kconfig File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/Kconfig... PS1, Line 319: 80x25
Does it work with other sizes as well, or is this only applicable to 80x25?
That's the default that was already hardcoded (and probably the only common setting anyway). We could make it configurable here in Kconfig. But I'd wait until somebody has a real use case for this.
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/corebootfb.c:
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/drivers... PS1, Line 244: /* adapt to the framebuffer size, otherwise. */
nit: add a blank line before this comment?
It felt like it belongs together. Let me know if you have strong feelings about it.