Stefan Reinauer (stefan.reinauer@coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8420
-gerrit
commit 9eb0e2e1c3db29faaa5d253b5fc2c8c8038e071d Author: Stefan Reinauer stefan.reinauer@coreboot.org Date: Wed Feb 11 01:56:38 2015 +0100
console: Fix broken early_print.h include guards
Make compilation fail if this is included in non-romcc compiles. I am a bit surprised that this ever compiled.
Change-Id: I8dfc1229681819d2381821a0195a89b44dd76b6a Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- src/include/console/early_print.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/include/console/early_print.h b/src/include/console/early_print.h index cbc9b46..f719e71 100644 --- a/src/include/console/early_print.h +++ b/src/include/console/early_print.h @@ -18,11 +18,14 @@ #ifndef __CONSOLE_EARLY_PRINT_H_ #define __CONSOLE_EARLY_PRINT_H_
+#if !defined(__ROMCC__) +#error "Don't include early_print.h" +#endif + #include <console/console.h> #include <console/streams.h> #include <console/loglevel.h>
-#if defined(__ROMCC__) /* While in romstage, console loglevel is built-time constant. * With ROMCC we inline this test with help from preprocessor. */