Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32532 )
Change subject: security/vboot/vboot_crtm.c: Use ENV_ conditions for vboot_measure_cbfs_hook() ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32532/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32532/2//COMMIT_MSG@10 PS2, Line 10: is enabled, but this function is defined as 0 in vboot_crtm.h using ENV_ Do we need all the ENV_ checks in the header? There's already a vboot_logic_executed() check in the function itself which should be compile-time decided to be false for those stages. We should try to reduce the tangle of #ifdefs where possible, so I'd say just remove the ENV_ checks from the header (it should only check for the Kconfig) and leave the function as is.