Attention is currently required from: YH Lin, Tarun Tuli, Subrata Banik, Kapil Porwal, Kun Liu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 )
Change subject: mb/google/rex: Initial setup for gpio config
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74475/comment/b0421dc7_7726b126
PS3, Line 2: liukun11
Please configure your user name.
$ git config --global user.name "…"
$ git commit --amend --author="… <…>"
https://review.coreboot.org/c/coreboot/+/74475/comment/e04948e3_3a6d7ff4
PS3, Line 7: mb/google/rex: Initial setup for gpio config
Please make it a statement, by adding a verb (in imperative mood); cf `git log --oneline`.
https://review.coreboot.org/c/coreboot/+/74475/comment/261072d0_7224bbe6
PS3, Line 9: add the initial gpio configuration for the screebo
What is the source for this?
https://review.coreboot.org/c/coreboot/+/74475/comment/7961884f_b88987dd
PS3, Line 14: liukun11
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74475
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
Gerrit-Change-Number: 74475
Gerrit-PatchSet: 3
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Zhou
zhouguohui@huaqin.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 17 Apr 2023 16:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment