Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32534 )
Change subject: soc/intel/apollolake: Reset GPI IS & IE registers at ramstage
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32534/1/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/32534/1/src/soc/intel/apollolake/chip.c@406
PS1, Line 406: gpi_clear_int_cfg
Can we do this before calling into fsp_silicon_init? Mainboard GPIO configuration is done before silicon init. So, it would be good to clear interrupt status and enable bits before that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32534
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib11b580ceb23bd1fe789f549b667a8ced2d859a1
Gerrit-Change-Number: 32534
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 03 May 2019 05:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment