Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36492 )
Change subject: mainboard/google: Move variant_memory_sku() to baseboard/ ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36492/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/romstage.c:
https://review.coreboot.org/c/coreboot/+/36492/2/src/mainboard/google/hatch/... PS2, Line 39: mem_sku = variant_memory_sku(); When it is a nop, what value would this return so that things continue to work in both memory down and dimms? In your other patch where we were reading the spd contents ourselves, I think that's ok and likely better. Along w/ my first question I'm wondering about this is_single_ch_mem discovery and if that makes sense. I think I may like the other approach, fwiw, as there's lots of specifics that become odd in comparing hatch to puff -- largely this memory topology.