Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19503 )
Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/19503/6/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c:
PS6, Line 669: gtt_res
It usually is guarded (and was in this function too before).
it still is on the native path and was not guarded on gma_pm_init_post_vbios(), so nothing changed?
Anyway I could guard against it since running option rom would fail too in that case I guess?
https://review.coreboot.org/#/c/19503/7/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c:
Line 694: }
Just move it below, right before the VGA decision?
ok