[coreboot-gerrit] [L] Change in coreboot[master]: security/tpm: resolve conflicts in TSS implementations

[Sergii Dmytruk (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Michał Żygowski, Frans Hendriks, Matt DeVillier, Christian Walter, Julius Werner, Krystian Hebel, Fred Reitberger, Yu-Ping Wu, Felix Held.

Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69160 )

Change subject: security/tpm: resolve conflicts in TSS implementations
......................................................................

Patch Set 9:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/69160/comment/a8d2e7f4_051e32e9 
PS9, Line 9: Just code updates to don't have
> Refactor code such that there won't be

Done

File src/security/tpm/tss/tss.c:

https://review.coreboot.org/c/coreboot/+/69160/comment/60804b97_01fba26a 
PS8, Line 22: VB2_SUCCESS
> Then we should change the return type to `vb2_error_t` (maybe in a follow-up patch), which is just a […]

That might be even more confusing, because these functions can also return codes from TPM (`TPM_E_*`).  `VB2_SUCCESS` and `TPM_SUCCESS` are both `0`, so you can interpret results both ways or as consisting of two kinds of complementary error sets (they shouldn't overlap).