[coreboot-gerrit] Change in coreboot[master]: cpu/intel/car: Skip stack integrity check if FSP_USES_CB_STACK is enable

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35165 )

Change subject: cpu/intel/car: Skip stack integrity check if FSP_USES_CB_STACK is enable
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35165/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35165/1//COMMIT_MSG@12 
PS1, Line 12: Don't need to run code logic to check the integrity of stack if FSP and
            : coreboot both likely to make use of common stack.
> Why? This is an assertion without an explanation. […]

I agree with Aaron. We should properly document what the FSP utilization of the stack is. Also, do we really want to skip the stack integrity check? Can we not tell FSP about the stack - guard band so that it does not end up using the guard band?