Attention is currently required from: Tim Wawrzynczak, Eric Lai.
Alan Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63191 )
Change subject: mb/google/brya/variants/baseboard/brask: Turn off NFC power in S0ix
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/brask/variant.c:
https://review.coreboot.org/c/coreboot/+/63191/comment/c7e974dc_a2f7a8d8
PS2, Line 7: #include <soc/gpio.h>
We probably can remove this.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69588c82dfde1744c45c7aff3ac05b80bb16a8f3
Gerrit-Change-Number: 63191
Gerrit-PatchSet: 3
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 30 Mar 2022 02:55:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment