Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34693 )
Change subject: soc/mediatek/mt8173: Remove dual DSI mode
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
forward jwerner's LGTM.
https://review.coreboot.org/c/coreboot/+/34693/2/src/soc/mediatek/mt8173/dsi...
File src/soc/mediatek/mt8173/dsi.c:
https://review.coreboot.org/c/coreboot/+/34693/2/src/soc/mediatek/mt8173/dsi...
PS2, Line 62: dsi_write32(&mipi_tx0->dsi_bg_con, reg);
Let's just switch all of these to the basic write32()/clrsetbits_le32() now.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34693
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I357c30cc687803ca8045d0b055dec2e22eef4291
Gerrit-Change-Number: 34693
Gerrit-PatchSet: 3
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Comment-Date: Wed, 07 Aug 2019 04:33:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment