[coreboot-gerrit] [S] Change in coreboot[master]: soc/amd/picasso/include/acpi: introduce and use ACPI_SCI_IRQ definition

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71912 )

Change subject: soc/amd/picasso/include/acpi: introduce and use ACPI_SCI_IRQ definition
......................................................................

soc/amd/picasso/include/acpi: introduce and use ACPI_SCI_IRQ definition

The newer AMD SoCs define ACPI_SCI_IRQ in the SoC's acpi.h header file
and use this definition in the mainboard code, so port this back to
Picasso.

Signed-off-by: Felix Held 
Change-Id: Ib569747aa388d7953e79de747905fb52c2a05e74
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71912
Tested-by: build bot (Jenkins) 
Reviewed-by: Fred Reitberger 
---
M src/mainboard/amd/bilby/mainboard.c
M src/mainboard/amd/mandolin/mainboard.c
M src/mainboard/google/zork/mainboard.c
M src/soc/amd/picasso/include/soc/acpi.h
4 files changed, 25 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Fred Reitberger: Looks good to me, approved

diff --git a/src/mainboard/amd/bilby/mainboard.c b/src/mainboard/amd/bilby/mainboard.c
index a751126..5e20946 100644
--- a/src/mainboard/amd/bilby/mainboard.c
+++ b/src/mainboard/amd/bilby/mainboard.c
@@ -5,6 +5,7 @@
 #include <amdblocks/amd_pci_util.h>
 #include <FspsUpd.h>
 #include <gpio.h>
+#include <soc/acpi.h>
 #include <soc/cpu.h>
 #include <soc/southbridge.h>
 #include <soc/pci_devs.h>
@@ -26,7 +27,7 @@
    { PIRQ_B,	10,		17 },
    { PIRQ_C,	11,		18 },
    { PIRQ_D,	12,		19 },
-	{ PIRQ_SCI,	9,		 9 },
+	{ PIRQ_SCI,	ACPI_SCI_IRQ,	ACPI_SCI_IRQ },
    { PIRQ_SD,	PIRQ_NC,	16 },
    { PIRQ_SDIO,	PIRQ_NC,	16 },
    { PIRQ_SATA,	PIRQ_NC,	19 },
diff --git a/src/mainboard/amd/mandolin/mainboard.c b/src/mainboard/amd/mandolin/mainboard.c
index 6a27514..d3b79e6 100644
--- a/src/mainboard/amd/mandolin/mainboard.c
+++ b/src/mainboard/amd/mandolin/mainboard.c
@@ -4,6 +4,7 @@
 #include <device/device.h>
 #include <amdblocks/amd_pci_util.h>
 #include <FspsUpd.h>
+#include <soc/acpi.h>
 #include <soc/cpu.h>
 #include <soc/southbridge.h>
 #include <soc/pci_devs.h>
@@ -21,7 +22,7 @@
    { PIRQ_B,	10,		17 },
    { PIRQ_C,	11,		18 },
    { PIRQ_D,	12,		19 },
-	{ PIRQ_SCI,	9,		 9 },
+	{ PIRQ_SCI,	ACPI_SCI_IRQ,	ACPI_SCI_IRQ },
    { PIRQ_SD,	PIRQ_NC,	16 },
    { PIRQ_SDIO,	PIRQ_NC,	16 },
    { PIRQ_SATA,	PIRQ_NC,	19 },
diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c
index 89460cc..74ed679 100644
--- a/src/mainboard/google/zork/mainboard.c
+++ b/src/mainboard/google/zork/mainboard.c
@@ -11,6 +11,7 @@
 #include <boardid.h>
 #include <gpio.h>
 #include <smbios.h>
+#include <soc/acpi.h>
 #include <soc/cpu.h>
 #include <soc/pci_devs.h>
 #include <soc/platform_descriptors.h>
@@ -52,7 +53,7 @@
    { PIRQ_G,	13,		PIRQ_NC },
    { PIRQ_H,	6,		PIRQ_NC },

-	{ PIRQ_SCI,	9,		9 },
+	{ PIRQ_SCI,	ACPI_SCI_IRQ,	ACPI_SCI_IRQ },
    { PIRQ_EMMC,	5,		5 },
    { PIRQ_GPIO,	7,		7 },
    { PIRQ_I2C2,	10,		10 },
diff --git a/src/soc/amd/picasso/include/soc/acpi.h b/src/soc/amd/picasso/include/soc/acpi.h
index 2087690..741b732 100644
--- a/src/soc/amd/picasso/include/soc/acpi.h
+++ b/src/soc/amd/picasso/include/soc/acpi.h
@@ -8,6 +8,8 @@
 #include <device/device.h>
 #include <stdint.h>

+#define ACPI_SCI_IRQ 9
+
 /* RTC Registers */
 #define RTC_DATE_ALARM		0x0d