Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48423 )
Change subject: soc/intel/common: Check sizes of CSE CBFS RW blob and CSE RW BP
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48423/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/48423/1/src/soc/intel/common/block/...
PS1, Line 680: region_device_sz(target_rdev) != cse_blob_sz
I don't think this check is correct. We need to ensure that the target_rdev size is greater than the size of blob being written. We cannot expect them to be the same always. Think of the scenarios where we start with larger RW size on flash where some part is left unused and blobs that are written to that region can be smaller.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8be589eae905b1a54a8cf981ccd3a00bd5e733f5
Gerrit-Change-Number: 48423
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 07 Dec 2020 19:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment