Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops
......................................................................
Patch Set 2:
(1 comment)
that one took a different turn than expected
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h@...
PS1, Line 227: pci_domain_ops
Actually, why is this required here? pci_domain_ops should really be a static object in chip.c.
oh, you're right. it is in chip.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia92b778a5882d991b391dc29aeee0a5615677913
Gerrit-Change-Number: 48315
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Sat, 05 Dec 2020 00:47:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment