Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32778 )
Change subject: libpayload: ahci: Prevent memory leaks when failing on init
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32778/2/payloads/libpayload/drivers/storage/...
File payloads/libpayload/drivers/storage/ahci.c:
https://review.coreboot.org/#/c/32778/2/payloads/libpayload/drivers/storage/...
PS2, Line 111: /* Set command list base and received FIS base. */
This comment applies more to the part of the block that […]
Done
https://review.coreboot.org/#/c/32778/2/payloads/libpayload/drivers/storage/...
PS2, Line 183: * still use the resources for DMA. */
Please use one of the commenting styles documented here: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32778
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6826d79338b26ff9696ab6ac9eb4c59f734687d8
Gerrit-Change-Number: 32778
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 14 May 2019 16:13:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment