Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45344 )
Change subject: soc/intel/common/block/cpu: Fix boot failure
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45344/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/45344/1/src/soc/intel/common/block/...
PS1, Line 349: if (!CONFIG(SOC_INTEL_COMMON_BLOCK_SGX))
: return 0;
CB:45345 would allow PRMRRs to be set without SGX
Looking at the Kconfig PRMRR is always disabled when SGX disabled, so this condition is correct.
https://review.coreboot.org/c/coreboot/+/45344/1/src/soc/intel/common/block/...
PS1, Line 352: if (CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_DISABLED)) {
: printk(BIOS_DEBUG, "PRMRR disabled by config.\n");
: return 0;
: }
What's this for, then?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d32ca32b1b53767b2db91305103cd532823a5ca
Gerrit-Change-Number: 45344
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Sep 2020 15:40:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment