[coreboot-gerrit] Change in ...coreboot[master]: mb/google/octopus/var/phaser: Hook up Raydium touchscreen

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Hook up Raydium touchscreen
......................................................................

Patch Set 3: Code-Review+2
> Patch Set 3:
> > Patch Set 2:
> >
> > (1 comment)
>
> Hi Paul,
> The value of enable_delay_ms may have no effect, because I did not see the use of enable_gpio in the driver. This part of the control is controlled by the chip itself.

To add more info, the delay is passed to the kernel and is not used by the I2C generic driver in coreboot. The touchscreen driver in kernel will use that delay when it asserts the enable GPIO. Hence no impact to the boot process.