Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33141 )
Change subject: mb/*/{x201,ms2290}/mainboard.c: Remove superfluous ramstage code
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/33141/2/src/mainboard/lenovo/x201/mainboard....
File src/mainboard/lenovo/x201/mainboard.c:
https://review.coreboot.org/#/c/33141/2/src/mainboard/lenovo/x201/mainboard....
PS2, Line 81:
:
:
:
Aren't these needed? Maybe they should go to a more common place, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0270c50dea2a2ce6c8e6114ed708f06be9d33c0e
Gerrit-Change-Number: 33141
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Jun 2019 19:06:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment