Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38862 )
Change subject: superio/nuvoton/npcd378: Switch to superio/common ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38862/2/src/superio/nuvoton/npcd378... File src/superio/nuvoton/npcd378/superio.c:
https://review.coreboot.org/c/coreboot/+/38862/2/src/superio/nuvoton/npcd378... PS2, Line 411: if (dev->path.pnp.device == NPCD378_PWR) : npcd378_ssdt_pwr(dev); : else if (dev->path.pnp.device == NPCD378_AUX) : npcd378_ssdt_aux(dev); : else if (dev->path.pnp.device == NPCD378_KBC) : npcd378_ssdt_kbc(dev); i'd write this as switch/case statement
https://review.coreboot.org/c/coreboot/+/38862/2/src/superio/nuvoton/npcd378... PS2, Line 435: pnp_enable is it intended that the pnp_alt_enable is replaced by a pnp_enable?