Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31477 )
Change subject: riscv: currently riscv does not support fit payload, remove redundant code ......................................................................
Patch Set 3:
(1 comment)
See my comment, this should fix all payload types.
https://review.coreboot.org/#/c/31477/3/src/arch/riscv/boot.c File src/arch/riscv/boot.c:
https://review.coreboot.org/#/c/31477/3/src/arch/riscv/boot.c@a35 PS3, Line 35: prog_entry_arg should contain the argument to the payload. So the problem is within selfboot as it puts the coreboot tables into args, whereas we need the fdt in the case of an elf payload.
I also discussed this with Ron and he also suggested to just work around it in riscv: Please do the following here:
/* * Workaround selfboot putting the coreboot table into prog_entry_arg */ if (prog_cbfs_type(payload) == CBFS_TYPE_SELF) { fdt = HLS()->fdt; break;